Highlight plugin check for empty strings #996
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: pom.xml ui-backend/catalog-ui-enumeration/pom.xml ui-backend/catalog-ui-oauth/pom.xml ui-backend/catalog-ui-search-api/pom.xml ui-backend/catalog-ui-search/pom.xml ui-backend/catalog-ui-splitter/pom.xml ui-backend/intrigue-ui-app/pom.xml ui-backend/pom.xml ui-frontend/pom.xml
derekwilhelm
approved these changes
Nov 14, 2024
derekwilhelm
approved these changes
Nov 14, 2024
|
build now |
|
Internal build has been started, your results will be available at build completion. |
|
Build FAILURE See the job results in legacy Jenkins UI or in Blue Ocean UI. |
Suspected Failure(s):
|
jlcsmith
reviewed
Nov 14, 2024
| @@ -46,6 +46,11 @@ | |||
| <groupId>org.slf4j</groupId> | |||
| <artifactId>slf4j-api</artifactId> | |||
| <version>${org.slf4j.version}</version> | |||
| </dependency> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why?
if the attribute that is redacted and has a value od empty string the highlight plugin was throwing an exception:
java.lang.StringIndexOutOfBoundsException: String index out of range: -5
HighlightTransformPlugin.java:161 - processedHighlight.addHighlight
Additional changes:
N/A
How should this be tested?
Unit test has been updated to include a test for empty strings.
PR Definition of Done
minimum 2 reviewer approval
All comments resolved (nit comments are the exception and left up to the author)
Passing CI (preferred) or alternatively full local build
Any exceptions to the above should be justified prior to merging