DEV2-4157: Add tabnine chat state #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimacodota
reviewed
Dec 3, 2023
src/utils/EventEmitterBasedState.ts
Outdated
| import { isEqual } from "underscore"; | ||
| import { Disposable, EventEmitter } from "vscode"; | ||
|
|
||
| export default class EventEmitterBasedState<T> { |
There was a problem hiding this comment.
i think it should be disposable bc EventEmitter is disposable.
moreover EventEmitterBasedState can extend EventEmitter instead of composition
dimacodota
reviewed
Dec 3, 2023
| @@ -0,0 +1,15 @@ | |||
| import EventEmitterBasedState from "./EventEmitterBasedState"; | |||
|
|
|||
| export default class EventEmitterBasedNonNullState< | |||
There was a problem hiding this comment.
why do you need this wrapper? in what case null state is valid?
There was a problem hiding this comment.
Mostly for typescript. Null is the default initial state. But this wrapper is for when you an actual initial state. By the current state design, the value is only null able before initialisation after that the state will never change back to null. And the listeners are only notified on when the non null value has changed.
dimacodota
reviewed
Dec 3, 2023
src/utils/deriveState.ts
Outdated
|
|
||
| export type DerivedState<T> = Disposable & EventEmitterBasedState<T>; | ||
|
|
||
| export default function deriveState<I, O, S extends EventEmitterBasedState<I>>( |
|
lets move all the "state management" under state folder instead of utils |
dimacodota
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.