Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV2-4419: enable chat for preview users #1403

Merged
merged 1 commit into from
Dec 10, 2023
Merged

DEV2-4419: enable chat for preview users #1403

merged 1 commit into from
Dec 10, 2023

Conversation

yairco1990
Copy link
Contributor

@yairco1990 yairco1990 commented Dec 6, 2023 •
edited
Loading

Screenshot from 2023-12-06 13-55-06

@yairco1990 yairco1990 requested a review from a team as a code owner December 6, 2023 11:57
@amircodota
Copy link
Contributor

@yairco1990 @dimacodota not sure if it is related directly to this PR, but depending on how you enabled chat, it does not necessarily dictate that you enabled local retrieval too.
Not sure if you intended to or not, but that's something to consider

dimacodota
dimacodota approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@dimacodota dimacodota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, @ofekby - pls take a look

ofekby
ofekby approved these changes Dec 10, 2023
View reviewed changes
Copy link
Contributor

@ofekby ofekby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yairco1990 yairco1990 merged commit d858755 into master Dec 10, 2023
3 of 4 checks passed
@yairco1990 yairco1990 deleted the yair/chat_for_preview_users branch December 10, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimacodota dimacodota dimacodota approved these changes

@ofekby ofekby ofekby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yairco1990 @amircodota @ofekby @dimacodota