Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Ukrainian to the list of languages #54

Merged
merged 6 commits into from
Nov 11, 2015
Merged

Adding Ukrainian to the list of languages #54

merged 6 commits into from
Nov 11, 2015

Conversation

Borales
Copy link
Contributor

@Borales Borales commented Nov 6, 2015

No description provided.

@norberttech
Copy link
Member

@Borales could you please

  1. rebase your branch against master
  2. check if you can translate also https://github.com/coduo/php-humanizer/blob/master/src/Coduo/PHPHumanizer/Resources/translations/oxford.en.yml
  3. add tests in
    DateTimeTest and
    CollectionTest
    (execute them by bin/phpunit)

:P

@Borales
Copy link
Contributor Author

Borales commented Nov 6, 2015

@norzechowicz dobrze :)

@Borales
Copy link
Contributor Author

Borales commented Nov 11, 2015

@norzechowicz ready

norberttech pushed a commit that referenced this pull request Nov 11, 2015
Merge pull request #54 from Borales/master
3bcb4b6 
Adding Ukrainian to the list of languages
@norberttech norberttech merged commit 3bcb4b6 into coduo:master Nov 11, 2015
@norberttech
Copy link
Member

@Borales awesome! Thanks! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Borales @norberttech