Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(plugin): v4.0.0 #315

Merged
merged 2 commits into from
Mar 19, 2018
Merged

refactor(plugin): v4.0.0 #315

merged 2 commits into from
Mar 19, 2018

Conversation

ryanclark
Copy link
Collaborator

@ryanclark ryanclark commented Mar 10, 2018

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

Doesn't support webpack 4's new plugin system

What is the new behavior?

It supports webpack 4's new plugin system

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the following...

  • Impact: upgrades webpack-dev-middleware to latest, making node minimum version 6.11.5
  • Migration path for existing applications: update to webpack 4

Fixes #314

@michael-ciniawsky michael-ciniawsky changed the title feat: add webpack 4 support refactor(karma-webpack): upgrade plugin system (tapable) && middleware (webpack-dev-middleware) Mar 10, 2018
@michael-ciniawsky michael-ciniawsky added this to the 3.0.0 milestone Mar 10, 2018
@iclanton
Copy link

Any word on when this is going to go in and 3.0.0 is going to get released?

@limonte
Copy link
Contributor

limonte commented Mar 15, 2018

FYI, package-lock.json is a joke, do not include it in PRs without strong reasons for that:

yarn.lock works just like expected though, but still both package-lock.json and yarn.lock are completely out of scope of this PR.

@a-tarasyuk
Copy link

+1 to question from @iclanton. Are there any issues that block review/merge? Or maybe need help to fix issues in order to deploy this update.

@michael-ciniawsky michael-ciniawsky changed the base branch from master to next March 16, 2018 14:05
@michael-ciniawsky
Copy link
Contributor

michael-ciniawsky commented Mar 16, 2018

I will release this under the @next tag on npm once https://status.npmjs.org/incidents/gbk5bjx1169j is resolved so folks can try it out :)

@michael-ciniawsky
Copy link
Contributor

@rynclark Could you do me a favor and split the commits this time with the following commit messages for the CHANGELOG 🙃

chore(package): update `webpack-dev-middleware` v1.12.0...3.0.1

BREAKING CHANGE: requires `node >= v6.9.0`
refactor(karma-webpack): upgrade plugin system (`tapable`)

BREAKING CHANGE: requires `webpack >= v4.0.0`

Copy link
Contributor

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rynclark Thx, nice work! :P

package.json Outdated
@@ -5,7 +5,7 @@
"description": "Use webpack with karma",
"license": "MIT",
"engines": {
"node": ">= 4"
"node": ">=6.11.5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>= 6.9.0

]
}

hooks.forEach(function(hook) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function is needed here to keep the context ? :)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think yes, as there is the second argument in line 150 which set this for the callback. The plugin uses ES5 syntax, not ES6, so I think it is ok to use the function here.

@michael-ciniawsky michael-ciniawsky changed the title refactor(karma-webpack): upgrade plugin system (tapable) && middleware (webpack-dev-middleware) refactor(plugin): v3.0.0 Mar 16, 2018
@a-tarasyuk
Copy link

@michael-ciniawsky

I will release this under the @next tag

Are there changes which need to be done in order to release stable version?

@limonte
Copy link
Contributor

limonte commented Mar 19, 2018

Are there changes which need to be done in order to release stable version?

https://github.com/webpack-contrib/karma-webpack/milestone/1

@a-tarasyuk
Copy link

@limonte thx. Is there a change that webpack-4 support will be released early? There are some issues which can take a lot of time, like issues related to performance.

BREAKING CHANGE: requires `webpack >= v4.0.0`
BREAKING CHANGE: requires `node >= v6.9.0`
@michael-ciniawsky michael-ciniawsky merged commit 3401a08 into codymikol:next Mar 19, 2018
@ryanclark ryanclark deleted the webpack-4 branch March 19, 2018 18:43
@michael-ciniawsky michael-ciniawsky changed the title refactor(plugin): v3.0.0 refactor(plugin): v4.0.0 Mar 19, 2018
@michael-ciniawsky
Copy link
Contributor

michael-ciniawsky commented Mar 19, 2018

Released in v4.0.0-beta.0 🎉 Thx

npm i -D karma-webpack@next

@thijstriemstra
Copy link

@michael-ciniawsky can you give any ETA for karma-webpack 4.0.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants