fix(karma-webpack): compilation hangs when adding a file
#345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-ciniawsky
changed the title
compilation hangs when adding a file
michael-ciniawsky
approved these changes
Sep 1, 2018
michael-ciniawsky
pushed a commit
that referenced
this pull request
Sep 1, 2018
michael-ciniawsky
pushed a commit
that referenced
this pull request
Sep 1, 2018
|
Released in |
ryanclark
added
severity: 3 (broken)
priority: 4 (important)
and removed
priority: 4 (important)
severity: 3 (broken)
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior?
During the refactoring, the method to add a file no longer returned
true, causing the whole process to stall and karma not to start.I'll add some integration tests ASAP.
Does this PR introduce a breaking change?