various updates #12
Merged
various updates #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codyps
force-pushed
the
wip
branch
3 times, most recently
from
6dfb5e4
to
266d6c3
Compare
Right now we see errors like:
```
= note: `.note.gnu.build-id' referenced in section `.text._ZN7buildid6target8build_id17he4d54dc30f90bfd5E' of /home/runner/work/buildid/buildid/target/debug/deps/libbuildid-0fe5f367bd5ea7ac.rlib(buildid-0fe5f367bd5ea7ac.buildid.acddeb1316d76d1f-cgu.0.rcgu.o): defined in discarded section `.note.gnu.build-id' of /home/runner/work/buildid/buildid/target/debug/deps/libbuildid-0fe5f367bd5ea7ac.rlib(buildid-0fe5f367bd5ea7ac.buildid.acddeb1316d76d1f-cgu.0.rcgu.o)
`.note.gnu.build-id' referenced in section `.text._ZN7buildid6target8build_id17he4d54dc30f90bfd5E' of /home/runner/work/buildid/buildid/target/debug/deps/libbuildid-0fe5f367bd5ea7ac.rlib(buildid-0fe5f367bd5ea7ac.buildid.acddeb1316d76d1f-cgu.0.rcgu.o): defined in discarded section `.note.gnu.build-id' of /home/runner/work/buildid/buildid/target/debug/deps/libbuildid-0fe5f367bd5ea7ac.rlib(buildid-0fe5f367bd5ea7ac.buildid.acddeb1316d76d1f-cgu.0.rcgu.o)
collect2: error: ld returned 1 exit status
```
When running `./scripts/test-gnu-ld-section-inject`. Possible that this
just no longer works with current rust or current gnu ld, etc.
codyps
force-pushed
the
wip
branch
3 times, most recently
from
9a969a5
to
4056307
Compare
This doesn't change section inject not working This reverts commit b0b09bd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.