This repository has been archived by the owner on Jun 23, 2023. It is now read-only.
Fix integer overflow during multiplication with realtic_clock_rate #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiangreffrath
suggested changes
Feb 15, 2022
When the program has run for about 26 minutes and SDL_GetTicks has accrued a reasonably large value, multiplication by realtic_clock_rate overflows "int" on contemporary platforms, manifesting in jagged motion. Fixes: v2.6.1um-29-ga7bafe07 Closes #471
|
I_TickElapsedTime_RealTime would overflow only after 17h, but yeah, there's that 23-day program runtime ;-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the program has run for about 26 minutes and SDL_GetTicks has
accrued a reasonably large value, multiplication by realtic_clock_rate
overflows "int" on contemporary platforms, manifesting in jagged
motion.
Fixes: v2.6.1um-29-ga7bafe07
Closes #471