This repository has been archived by the owner on Jun 23, 2023. It is now read-only.
Don't overwrite user-configured custom docdir #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please add a comment? I know I won't understand this change anymore in a few moths. 😉 |
vilhelmgray
force-pushed
the
custom_docdir
branch
from
75f5b8e to
71a0670
Compare
|
I've updated the commit message to matched the discussion we had in daa4544 |
|
Oh I'll add a comment in the file as well. |
We want to provide a default docdir for PrBoom-Plus, but let's not
overwrite the custom docdir a user may provide.
We can't simply set the ${CMAKE_INSTALL_DOCDIR} in the CMakeLists.txt
file because the GNUInstallDirs has already set the
${CMAKE_INSTALL_DOCDIR} cache variable before a later set command; that
later set command is prevented from changing an already set cache
variable. The way to solve this is to check if ${CMAKE_INSTALL_DOCDIR}
is set before the include(GNUInstallDirs), and then only set the default
location when needed.
vilhelmgray
force-pushed
the
custom_docdir
branch
from
71a0670 to
9a4cbd7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to provide a default docdir for PrBoom-Plus, but let's not
overwrite the custom docdir a user may provide.