This repository has been archived by the owner on Jun 23, 2023. It is now read-only.
Generate mixer buffer size from sample rate #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facespkz
changed the title
fabiangreffrath
suggested changes
Mar 9, 2022
fabiangreffrath
suggested changes
Mar 9, 2022
prboom2/src/SDL/i_sound.c
Outdated
| { | ||
| int limit, n; | ||
|
|
||
| if (snd_samplecount) return snd_samplecount; |
There was a problem hiding this comment.
Please do the following:
if (snd_samplecount >= 32)
return snd_samplecount * snd_samplerate / 11025;
so users can keep their config if they fine-tuned it with the previous implementation.
There was a problem hiding this comment.
Good idea. Since those users have likely moved away from 512, I'll put this condition too:
if ((snd_samplecount >= 32) && (snd_samplecount != 512))
return snd_samplecount * snd_samplerate / 11025;
There was a problem hiding this comment.
No, please don't. We don't need two "do nothing else" cases.
There was a problem hiding this comment.
I admit that it's a hack, but shouldn't we handle the previous default? Or would it be safer to just do this for newer installs?
fabiangreffrath
suggested changes
Mar 9, 2022
fabiangreffrath
approved these changes
Mar 9, 2022
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #429, but breaks
slice_samplecountbehavior. Suggested re-usage on line 234.