This repository has been archived by the owner on Jun 23, 2023. It is now read-only.
Add configurable reverb and chorus for PortMidi #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to configure two commonly adjusted settings: reverb and chorus. These values will work with any MIDI file that doesn't already set reverb or chorus, such as the original Doom 1 and 2 music. Otherwise, the MIDI file settings have priority.
The motivation behind this addition is that a reset sets the reverb to 40 and chorus to 0, per MIDI specifications. However, some users may prefer control over these values if they were used to a different setting before (see: fabiangreffrath/crispy-doom#940).
New settings in prboom-plus.cfg:
mus_portmidi_reverb_level 40(0 to 127)mus_portmidi_chorus_level 0(0 to 127)