Skip to content
This repository has been archived by the owner on Jun 23, 2023. It is now read-only.

Fix FluidSynth mode and polyphony #550

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Fix FluidSynth mode and polyphony #550

merged 1 commit into from
Dec 5, 2022

Conversation

ceski-1
Copy link
Contributor

@ceski-1 ceski-1 commented Dec 4, 2022

This PR sets midi-bank-select and polyphony values to their defaults: gs and 256, respectively.

PrBoom+ used to have typos that meant default values were used for midi-bank-select and polyphony and that was fine. 495fd59 fixed the typos, so PrBoom+ started using poorly chosen values that cause notes to drop or cut out and disables GS features if a MIDI file uses them.

Download this: polyphony.zip

prboom-plus.exe -iwad doom2.wad -file polyphony.wad -warp 1

Listen to the trombone that plays in the left channel. If it cuts out, the polyphony is set too low.

References:

@fabiangreffrath fabiangreffrath merged commit 2689310 into coelckers:master Dec 5, 2022
@fabiangreffrath
Copy link
Collaborator

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants