This repository has been archived by the owner on Jun 23, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets midi-bank-select and polyphony values to their defaults: gs and 256, respectively.
PrBoom+ used to have typos that meant default values were used for midi-bank-select and polyphony and that was fine. 495fd59 fixed the typos, so PrBoom+ started using poorly chosen values that cause notes to drop or cut out and disables GS features if a MIDI file uses them.
Download this: polyphony.zip
Listen to the trombone that plays in the left channel. If it cuts out, the polyphony is set too low.
References: