Skip to content
This repository has been archived by the owner on Jun 23, 2023. It is now read-only.

Replace win_fopen.c with wrappers used in Chocolate Doom #554

Merged
merged 4 commits into from
Dec 23, 2022

Conversation

rfomin
Copy link
Contributor

@rfomin rfomin commented Dec 23, 2022

Fixes autoload and environmental variables (DOOMWADDIR etc) with non-Latin paths.

@@ -14,4 +14,3 @@ cmake_install.cmake
/prboom2/prboom-plus
/prboom2/prboom-plus-game-server
/prboom2/prboom-plus.wad
/prboom2/build*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this some time ago by mistake when I was implementing win_fopen.c.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, okay.

Copy link
Collaborator

@fabiangreffrath fabiangreffrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fabiangreffrath
Copy link
Collaborator

MacOS fails.

@rfomin
Copy link
Contributor Author

rfomin commented Dec 23, 2022

MacOS fails.

Fixed in c7d7451. Also I successfully built it in MSYS2.

@fabiangreffrath
Copy link
Collaborator

Great, thanks again.

@fabiangreffrath fabiangreffrath merged commit bddfb3b into coelckers:master Dec 23, 2022
@rfomin rfomin deleted the non_latin branch December 24, 2022 00:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants