-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: mock scatter plot functionality #279
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #279 +/- ##
==========================================
+ Coverage 91.25% 91.28% +0.03%
==========================================
Files 106 107 +1
Lines 3863 3891 +28
Branches 839 845 +6
==========================================
+ Hits 3525 3552 +27
Misses 208 208
- Partials 130 131 +1
|
neringaalt
reviewed
Aug 5, 2024
…kept it in the dataset folder. The test script is not using the sample data file from the dataset folder
neringaalt
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The added functionality allows you to create a time series where the timestamps is scaled with the "x-parameter", such that the scatter plot is superimposed on the time series chart. Both the "x-vector" and the "y-vector" are calculated, allowing you to plot the "x-vector" allowing you to read the x-value in addition to the y-value
Motivation and Context
Today it is not possible to plot scatter type of plots. This is a very important tool in many situations where the change over time is not the most important factor, but instead change as a function of another parameter. Typical examples are equipment performance as a function of load, choke performance as a function of opening,+++
How Has This Been Tested?
Tested for a production choke CV curve case where the output is superimposed on the timeseries plot
Tested on Windows 11 using python 3.10.7
Screenshots (if appropriate):
Types of changes
Contributor Checklist:
fix: <description>
,feat: <description>
, etc.Reviewer Checklist for Charts compliant functions: