-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Bugfix for the mock scatter plot #315
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrong scaling of the x-values
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #315 +/- ##
=======================================
Coverage 91.23% 91.23%
=======================================
Files 109 109
Lines 3969 3970 +1
Branches 858 857 -1
=======================================
+ Hits 3621 3622 +1
Misses 212 212
Partials 136 136
|
neringaalt
reviewed
Sep 16, 2024
neringaalt
reviewed
Sep 16, 2024
neringaalt
reviewed
Sep 16, 2024
neringaalt
reviewed
Sep 16, 2024
Co-authored-by: Neringa Altanaite <neringa.altanaite@cognite.com>
Co-authored-by: Neringa Altanaite <neringa.altanaite@cognite.com>
neringaalt
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrong scaling of the x-values
Description
The scaling for the x-values, was incorrect
Motivation and Context
Bugfix
How Has This Been Tested?
Tested using a case that failed via Charts (where the bug was detected)
Rerun all existing tests
Screenshots (if appropriate):
Types of changes
Contributor Checklist:
fix: <description>
,feat: <description>
, etc.Reviewer Checklist for Charts compliant functions: