Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bugfix for the mock scatter plot #315

Merged
merged 9 commits into from
Sep 16, 2024
Merged

Conversation

gunnarstaff
Copy link
Contributor

Wrong scaling of the x-values

Description

The scaling for the x-values, was incorrect

Motivation and Context

Bugfix

How Has This Been Tested?

Tested using a case that failed via Charts (where the bug was detected)
Rerun all existing tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Contributor Checklist:

  • My code follows the code style of this project.
  • I have added an example of my new feature and included it in the documentation.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My Pull Request name follows the naming convention fix: <description>, feat: <description>, etc.

Reviewer Checklist for Charts compliant functions:

  • The docstrings of the new function follow the contributing guidelines.
  • The new function is professionally documented
  • The new function and associated scripts are covered by one or more unit tests and code coverage did not decrease.
  • The new function is accompanied by an example and it is included in the Gallery of Charts.
  • The new function is reviewed in Chromatic. Access the storybook build results url and comment, approve or deny.
  • All function inputs, arguments, and outputs have a supported data type and have human readable names.
  • No code language is included in the description of the function or parameters (e.g use "polynomial order" instead of "poly_order")

Wrong scaling of the x-values
@gunnarstaff gunnarstaff requested review from a team and redzaroslii September 15, 2024 12:38
Copy link

codecov bot commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.23%. Comparing base (1a87492) to head (367e908).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #315   +/-   ##
=======================================
  Coverage   91.23%   91.23%           
=======================================
  Files         109      109           
  Lines        3969     3970    +1     
  Branches      858      857    -1     
=======================================
+ Hits         3621     3622    +1     
  Misses        212      212           
  Partials      136      136           
Files with missing lines Coverage Δ
indsl/resample/mock_scatter_plot.py 96.42% <100.00%> (+0.13%) ⬆️

Copy link

github-actions bot commented Sep 15, 2024

Unit Test Results

    15 files  ±0      15 suites  ±0   27m 0s ⏱️ +8s
 1 130 tests ±0   1 130 ✅ ±0  0 💤 ±0  0 ❌ ±0 
11 163 runs  ±0  11 154 ✅ ±0  9 💤 ±0  0 ❌ ±0 

Results for commit 367e908. ± Comparison against base commit 1a87492.

♻️ This comment has been updated with latest results.

gunnarstaff and others added 5 commits September 16, 2024 11:03
Co-authored-by: Neringa Altanaite <neringa.altanaite@cognite.com>
Co-authored-by: Neringa Altanaite <neringa.altanaite@cognite.com>
@neringaalt neringaalt merged commit 03749d6 into main Sep 16, 2024
25 checks passed
@neringaalt neringaalt deleted the gstaff/mock_scatter_debug branch September 16, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants