Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Neat-635] public examples #839

Merged
merged 7 commits into from
Dec 13, 2024
Merged

[Neat-635] public examples #839

merged 7 commits into from
Dec 13, 2024

Conversation

Juliamg
Copy link
Collaborator

@Juliamg Juliamg commented Dec 12, 2024

No description provided.

Copy link

github-actions bot commented Dec 12, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
14684 9782 67% 60% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cognite/neat/_session/_base.py 79% 🟢
cognite/neat/_session/_drop.py 87% 🟢
cognite/neat/_session/_inspect.py 38% 🟢
cognite/neat/_session/_mapping.py 86% 🟢
cognite/neat/_session/_prepare.py 56% 🟢
cognite/neat/_session/_read.py 55% 🟢
cognite/neat/_session/_set.py 92% 🟢
cognite/neat/_session/_show.py 33% 🟢
cognite/neat/_session/_to.py 67% 🟢
TOTAL 66% 🟢

updated for commit: 9ac0fb3 by action🐍

@Juliamg
Copy link
Collaborator Author

Juliamg commented Dec 13, 2024

Added an html file of the data model show output, but the formatting is weird and all links become hyperlinks on the page.. Not sure if it should be included in this PR until I have figured out a way to fix it?
Screenshot 2024-12-13 at 12 51 49

@@ -1 +1,2 @@
::: cognite.neat._session._show
::: cognite.neat._session._show.ShowAPI
--8<-- "docs/artifacts/figs/information_data_model.html"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is where the html file is added

Copy link
Collaborator

@doctrino doctrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

Comment on lines +303 to +305
type_described_in_table = "Turbine"
column_with_identifier = "UNIQUE_TAG_NAME"
neat.read.csv("url_or_path_to_csv_file", type=type_described_in_table, primary_key=column_with_identifier)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of variables to document.

@doctrino
Copy link
Collaborator

doctrino commented Dec 13, 2024

Added an html file of the data model show output, but the formatting is weird and all links become hyperlinks on the page.. Not sure if it should be included in this PR until I have figured out a way to fix it?

Did not notice that in the initial review, but lets skip it for now then.

@Juliamg Juliamg merged commit 25bd9bf into main Dec 13, 2024
7 checks passed
@Juliamg Juliamg deleted the NEAT-635-public-examples branch December 13, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants