Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEAT-651] 😃 Increase useability #855

Merged
merged 13 commits into from
Dec 19, 2024
Merged

[NEAT-651] 😃 Increase useability #855

merged 13 commits into from
Dec 19, 2024

Conversation

doctrino
Copy link
Collaborator

@doctrino doctrino commented Dec 19, 2024 •
edited
Loading

image

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 19, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
14836 9997 67% 60% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cognite/neat/_issues/_base.py 83% 🟢
cognite/neat/_issues/warnings/_resources.py 100% 🟢
cognite/neat/_rules/_shared.py 84% 🟢
cognite/neat/_rules/exporters/_base.py 87% 🟢
cognite/neat/_rules/exporters/_rules2dms.py 69% 🟢
cognite/neat/_rules/exporters/_rules2excel.py 76% 🟢
cognite/neat/_rules/exporters/_rules2instance_template.py 38% 🟢
cognite/neat/_rules/exporters/_rules2ontology.py 88% 🟢
cognite/neat/_rules/exporters/_rules2yaml.py 81% 🟢
cognite/neat/_rules/models/_base_rules.py 89% 🟢
cognite/neat/_rules/models/dms/_rules.py 86% 🟢
cognite/neat/_rules/models/dms/_rules_input.py 89% 🟢
cognite/neat/_rules/models/information/_rules.py 86% 🟢
cognite/neat/_rules/models/information/_rules_input.py 96% 🟢
cognite/neat/_rules/transformers/_converters.py 70% 🟢
cognite/neat/_session/_base.py 75% 🟢
cognite/neat/_session/_read.py 53% 🟢
cognite/neat/_session/_show.py 31% 🟢
cognite/neat/_session/_state.py 84% 🟢
cognite/neat/_store/_rules_store.py 77% 🟢
cognite/neat/utils/rdf.py 73% 🟢
TOTAL 77% 🟢

updated for commit: ab105ad by action🐍

@doctrino doctrino marked this pull request as ready for review December 19, 2024 13:42
@doctrino doctrino requested a review from a team as a code owner December 19, 2024 13:42
Juliamg
Juliamg reviewed Dec 19, 2024
View reviewed changes
cognite/neat/_rules/models/dms/_rules_input.py
@@ -289,6 +290,14 @@ def dump(self) -> dict[str, Any]:
"Nodes": [node_type.dump(default_space) for node_type in self.nodes or []] or None,
}

@classmethod
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not make this a property as well?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Classmethods cannot be properties

@doctrino doctrino requested a review from Juliamg December 19, 2024 13:59
@doctrino doctrino merged commit 07242f5 into enforce-linearity Dec 19, 2024
7 checks passed
@doctrino doctrino deleted the increase-useability branch December 19, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Juliamg Juliamg Juliamg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doctrino @Juliamg