Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix invalid html output for issue list #858

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

doctrino
Copy link
Collaborator

No description provided.

@@ -421,7 +421,7 @@
{
"data": {
"text/html": [
"<p>Succeeded with warnings: UnverifiedInformationModel &#8594; VerifiedInformationModel</p><br<div>\n",
"<p>Succeeded with warnings: UnverifiedInformationModel &#8594; VerifiedInformationModel</p><br /><div>\n",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The missing / that broke the docs.

@@ -485,7 +485,7 @@ def _repr_html_(self) -> str | None:
table = agg_df._repr_html_() # type: ignore[operator]
else:
table = agg_df.head()._repr_html_() # type: ignore[operator]
body += f"<br{table}"
body += f"<br />{table}"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the bug.

Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
14920 10060 67% 60% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cognite/neat/_issues/_base.py 83% 🟢
TOTAL 83% 🟢

updated for commit: 2d0da6c by action🐍

@doctrino doctrino merged commit 5375048 into main Dec 20, 2024
7 checks passed
@doctrino doctrino deleted the fix-broken-docs branch December 20, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants