[CDF-23514] 🎢 Inlined transformation #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doctrino
commented
Dec 10, 2024
| @@ -252,21 +274,6 @@ def load_resource( | |||
| ) | |||
| except KeyError as e: | |||
| raise ToolkitYAMLFormatError("authentication property is missing required fields", filepath, e) | |||
|
|
|||
| query_file: Path | None = filepath.parent / Path(transformation.query or "") | |||
There was a problem hiding this comment.
This seems to have raised an OS error on mac. Cannot recreate it on Windows.
There was a problem hiding this comment.
Anyways, it is a poor solution to overuse the query key for both a path and an actual query. So introduced the queryFile instead, and changed the logic to work on the raw dictionary.
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
ronpal
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please describe the change you have made.
Checklist
_version.py and
pyproject.toml per semantic versioning.