-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated infield standard config to latest changes #822
base: main
Are you sure you want to change the base?
Conversation
skipOnVersionConflict: false | ||
replace: true | ||
nodes: | ||
- space: cognite_app_data # should we have a separate space to avoid users overwriting config? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danlevings I believe @erikangelsen-cognite had a concern regarding allowing users access to this space and the risk of corrupting the config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- space: cognite_app_data # should we have a separate space to avoid users overwriting config? | |
- space: cognite_app_config_data | |
Talked to Dan and we want to add a new space for holding config data
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Did we setup the creation of 'application-configurators' group ? None of these groups now has the access to write config data.
- Should this PR also hold the module changes for writing location to ADS?
@@ -95,6 +95,6 @@ capabilities: | |||
spaceIdScope: { | |||
spaceIds: [ | |||
'cognite_app_data', # this space must be created to store user profile information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'cognite_app_data', # this space must be created to store user profile information | |
'cognite_app_data', # this space must be created to store user profile information | |
'cognite_app_config_data', # this space must be created to store config data |
@@ -95,6 +95,6 @@ capabilities: | |||
spaceIdScope: { | |||
spaceIds: [ | |||
'cognite_app_data', # this space must be created to store user profile information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'cognite_app_data', # this space must be created to store user profile information | |
'cognite_app_data', # this space must be created to store user profile information | |
'cognite_app_config_data', # this space must be created to store config data |
@@ -95,6 +95,6 @@ capabilities: | |||
spaceIdScope: { | |||
spaceIds: [ | |||
'cognite_app_data', # this space must be created to store user profile information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'cognite_app_data', # this space must be created to store user profile information | |
'cognite_app_data', # this space must be created to store user profile information | |
'cognite_app_config_data', # this space must be created to store config data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also add it to the read only group, didnt have the option to suggest it.
Description
Please describe the change you have made.
Checklist
_version.py and
pyproject.toml per semantic versioning.