Centralize client fixture #1023
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusaderky
force-pushed
the
guido/client_fixture
branch
2 times, most recently
from
e9e90bb to
1c28f0c
Compare
crusaderky
force-pushed
the
guido/client_fixture
branch
from
1c28f0c to
a83cc0f
Compare
|
Abandoning this, as it's nowhere near working and the cost/benefit ratio is way too low. The original benefit, to have a single point that starts a cluster which can be polished and filled with hacks and workarounds, is much less important than before thanks to upstream changes in coiled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace small_client and parquet_client with the generic 'client' fixture already used by workflows.
I left spill_client there for now as it has the additional complication of having custom config.