Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add migration for tpch tests restructure from #1094 and #1044 #1105

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Add migration for tpch tests restructure from #1094 and #1044 #1105

merged 2 commits into from
Oct 20, 2023

Conversation

milesgranger
Copy link
Contributor

@milesgranger milesgranger commented Oct 18, 2023 •
edited
Loading

Manually checked this out from the benchmark db on S3; after migration is applied:

image

@milesgranger milesgranger requested a review from fjetter October 18, 2023 12:31
@hendrikmakait
Copy link
Member

IIUC, we still lack a migration for the changes in #1044, which should arguably be applied before the migration for #1094. Is that correct?

@milesgranger milesgranger force-pushed the milesgranger/benchmark-db-migration branch from c39f833 to 16e5191 Compare October 18, 2023 18:35
@milesgranger
Copy link
Contributor Author

Good catch @hendrikmakait! 🙏

@milesgranger milesgranger changed the title Add migration for tpch tests restructure from #1094 Add migration for tpch tests restructure from #1094 and #1044 Oct 20, 2023
hendrikmakait
hendrikmakait approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dashboard finally looks good again, thanks!

@hendrikmakait hendrikmakait merged commit 96e10aa into main Oct 20, 2023
15 checks passed
@milesgranger milesgranger deleted the milesgranger/benchmark-db-migration branch October 20, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hendrikmakait hendrikmakait hendrikmakait approved these changes

@fjetter fjetter Awaiting requested review from fjetter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milesgranger @hendrikmakait