Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename and remove some files #46

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Rename and remove some files #46

merged 1 commit into from
Apr 23, 2024

Conversation

mrocklin
Copy link
Member

This renames some files and removes some old ones.

@jrbourbeau I'm curious about your thoughts on this

@fjetter @phofl @hendrikmakait I'm doing this to try to streamline some of your experience at pycon-de. I could be misguided though.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mrocklin
Copy link
Member Author

Ping @jrbourbeau (but no rush)

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrocklin. I'd like to keep the Dockerfile for now as it's used in the Coiled getting started guide. Otherwise this LGTM

Dockerfile Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to keep this as it's used to generate our coiled/gpu-examples docker image that's used in the "Getting Started" section in the app.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed I think

@mrocklin mrocklin force-pushed the cleanup-notebooks branch from d428078 to 0b3c7be Compare April 23, 2024 21:29
@jrbourbeau
Copy link
Member

Thanks @mrocklin

@jrbourbeau jrbourbeau merged commit b0f55c6 into main Apr 23, 2024
3 checks passed
@jrbourbeau jrbourbeau deleted the cleanup-notebooks branch April 23, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants