Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optimization flag for release to cmakelists #67

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TimSiebert1
Copy link
Collaborator

This PR consists of

  • "O3" flag for 'CMAKE_BUILD_TYPE=Release'
  • include the corresponding command to README.md

Was suggested by @juanlucasrey

@juanlucasrey
Copy link
Contributor

Hi Tim, thanks for the PR.

/home/runner/work/ADOL-C/ADOL-C/ADOL-C/boost-test/traceOperatorVector.cpp(2851): error: in "trace_vector/FmaxOperator_FOV_Forward_3": check yd[0][1] == aDerivative has failed [-0 != 1]: absolute value exceeds tolerance [|1| > 1e-08]
/home/runner/work/ADOL-C/ADOL-C/ADOL-C/boost-test/traceOperatorVector.cpp(2987): error: in "trace_vector/FminOperator_FOV_Forward_1": check yd[0][1] == bDerivative has failed [0 != -3.7000000000000002]: absolute value exceeds tolerance [|-3.7| > 1e-08]

Funny you get those errors. -O3 should be safe in the sense that it does not do unsafe optimisations. (for unsafe optimisations usually "-Ofast" is used, although it is not recommended)

These differences are not small, so they could be due to uninitialised variables somewhere. I can check further into it if you don't have time.

@TimSiebert1
Copy link
Collaborator Author

Hi Lucas,

this error is actually not related to the optimization flag. The test failed before too. If I remember correctly, there should be a mistake in this test. I wanted to fix it this week, but if you have time to work on it, we would appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants