expend the tablesize range #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeekArthur
previously approved these changes
Aug 26, 2022
jingweicb
force-pushed
the
jingwei/inMemory-update
branch
from
ca5618b
to
91fabc1
Compare
cb-heimdall
dismissed
GeekArthur’s stale review
Approved review 1087002592 from GeekArthur is now dismissed due to new commit. Re-request for approval.
GeekArthur
previously requested changes
Sep 19, 2022
configuration/configuration.go
Outdated
| if config.TableSize != nil && (*config.TableSize < 2 || *config.TableSize > 100) { | ||
| return fmt.Errorf("table size %d is invalid: %w", *config.TableSize, cliErrs.ErrTableSizeIsOutOfRange) | ||
| if config.TableSize != nil && (*config.TableSize < 1 || *config.TableSize > 100) { | ||
| return fmt.Errorf("table_size %d is not in the range [1, 100], please check your input", *config.TableSize) |
There was a problem hiding this comment.
For table size range update, we should update ErrTableSizeIsOutOfRange instead of updating wrapping error message
cb-heimdall
dismissed
GeekArthur’s stale review
Approved review 1112749671 from GeekArthur is now dismissed due to new commit. Re-request for approval.
jingweicb
force-pushed
the
jingwei/inMemory-update
branch
from
a6f56bb
to
9c1d2fa
Compare
GeekArthur
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Motivation
Solution
Open questions