Fix: Use amount of 0 for currencies not listed #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready for review. Would @patrick-ogrady or @juliankoh be able to review this or tag someone on here who could? Thanks! |
fkneeland-figure
changed the title
Hey @fkneeland-figure . Thanks for creating this. I will take a look at this. |
xiaying-peng
previously approved these changes
Nov 27, 2021
fkneeland-figure
force-pushed
the
allow_unkown_balances
branch
from
9275329
to
77089e2
Compare
|
@xiaying-peng thanks for the review! I rebased and pushed up with a verified commit to meet merge requirements. |
shrimalmadhur
approved these changes
Dec 2, 2021
This was referenced Dec 8, 2021
mergify bot
pushed a commit
to cosmos/cosmos-sdk
that referenced
this pull request
Dec 9, 2021
<!-- The default pull request template is for types feat, fix, or refactor. For other templates, add one of the following parameters to the url: - template=docs.md - template=other.md --> ## Description A fix to rosetta was recently merged and tagged for an issue with rosetta causing tests to fail on chains with coins minted post genesis. We should consume this fix: coinbase/mesh-sdk-go#358 Closes: #10706 <!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. --> --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [x] added a changelog entry to `CHANGELOG.md` - [x] included comments for [documenting Go code](https://blog.golang.org/godoc) - [x] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [x] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes coinbase/mesh-cli#230
Motivation
When using rosetta with cosmos-sdk based blockchains with coins minted after Genesis rosetta-cli tests error because of missing account balances.
Solution
To solve this issue, instead of returning an error when searching for a balance for a currency that doesn't have a value return a 0 amount. This means that if rosetta looks for the amount of a currency at a block height before it has been minted it will simply return a 0 amount.
Open questions