add customized info in sdk's fetcher, reconciler, syncer and db #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Aim to enable customized logs in sdk
why added in fetcher, reconciler, syncer and db instead of other packages?
because they are the most frequent used packages for cli
will add to other packages?
yes, but the priority is not as high as fetcher, reconciler, syncer and db
notifications:
make changes are related to check-gen and go lint, for the first commit contains most important content
for the meteData in struct, it will be "", or some string begin with", "
Motivation
Solution
Open questions