Remove ProjectID, Add GHA #17
Conversation
.github/workflows/lint.yaml
Outdated
|
|
||
| on: | ||
| push: | ||
| # branches: |
There was a problem hiding this comment.
Good catch. I commented for testing initially, but I'll uncomment now 😄.
| with: | ||
| node-version: '18.x' | ||
| registry-url: 'https://registry.npmjs.org' | ||
| node-version: "20.x" |
There was a problem hiding this comment.
curious if we need to update our require node version docs anywhere else ? not sure.
There was a problem hiding this comment.
Hmmm. I moved to 20.x because that's the version specified in package.json. I'll update the README here as well. If we see anywhere else that's on 18.x, let's update it there too.
| 'holesky', | ||
| true, | ||
| 'your-wallet-address', // replace with your wallet address | ||
| '0xdb816889F2a7362EF242E5a717dfD5B38Ae849FE', // replace with your wallet address |
There was a problem hiding this comment.
can we roll this back ? or was this intentional ?
There was a problem hiding this comment.
Per offline discussion: Will keep in for simplicity of the example 😄.
| throw new Error( | ||
| 'Please set the projectId and stakerAddress variables in this file', | ||
| 'Please set the privateKey and stakerAddress variables in this file', |
There was a problem hiding this comment.
- can we update check to look for both priv key and walletAddress
- can we update message to reflect both priv key and walletAddress
There was a problem hiding this comment.
Yup, good catch. I'll double check these error messages in this repo to ensure they're correct as well.
examples/solana/create-workflow.ts
Outdated
| 'Please set the projectId and stakerAddress variables in this file', | ||
| ); | ||
| if (walletAddress === '') { | ||
| throw new Error('Please set the stakerAddress variable in this file'); |
This PR removes the project ID from the Typescript client. Further, we've added a GHA that lints the codebase, replicating the process we do manually.