Chore: Compatibility of RN 0.74 and Expo SDK 51 #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
|
Nicely done! Thanks @alantoa |
|
Hey @honeybadger26, could you please release it on npm? I noticed that it's available on GitHub but not on npm...
|
|
Hi @alantoa. There were a few TypeScript errors that prevented the build (and publish) of the package. I aim to fix those and get a release out as soon as I can. |
|
@alantoa v2.5.1 has been released to npm :) |
|
@honeybadger26 thank you! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
During our project upgrade to expo sdk 51 and RN 0.74, i noticed that this lib some types are outdated with Reanimated and RN.
This PR is compatible with the latest versions of Expo and RN.
How
Replacing Animated.SharedValue with SharedValue directly because renimated is deprecated with an old type.
During testing the example project, I noticed that many configurations and libraries in the project are already outdated. For instance, the app.json configuration is already out of date. You can refer to the latest documentation here for instructions on updating it.
And now I'm using Yarn 3 to integrate example and library code. It's simple and doesn't rely on too much configuration.
Test
I have tested the web and iOS app, and they all work well.
CleanShot.2024-05-15.at.21.30.57.mp4
Let me know if you guys have any questions about this PR!