Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix argument parsing in newer Python. #635

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

clalancette
Copy link
Contributor

The comment in the code has more details, but as of python/cpython#114180 we need to check for both a 3-tuple and a 4-tuple.

@clalancette clalancette requested a review from cottsay April 9, 2024 13:52
@clalancette clalancette force-pushed the clalancette/fix-parse-optional branch 2 times, most recently from 6230515 to b39c91c Compare April 9, 2024 14:01
Copy link
Member

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me get CI back on track and circle back here before merging.

colcon_core/command.py Outdated Show resolved Hide resolved
@cottsay cottsay self-assigned this Apr 9, 2024
@cottsay cottsay added the bug Something isn't working label Apr 9, 2024
@cottsay cottsay added this to the 0.16.1 milestone Apr 9, 2024
@clalancette clalancette force-pushed the clalancette/fix-parse-optional branch from 8c937fe to f04372b Compare April 9, 2024 16:01
clalancette and others added 3 commits April 9, 2024 12:01
The comment in the code has more details, but as of
python/cpython#114180 we need to
check for both a 3-tuple and a 4-tuple.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>

Co-authored-by: Scott K Logan <logans@cottsay.net>
@cottsay cottsay merged commit b04d936 into master Apr 9, 2024
40 checks passed
@delete-merged-branch delete-merged-branch bot deleted the clalancette/fix-parse-optional branch April 9, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants