Add colcon_core.logging.get_effective_console_level function #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When colcon routes log messages to log files at a different level from the console, it makes it a little more convoluted to determine what log level is actually set. When we're utilizing non-colcon libraries that also use python's logging module, we'll typically want to "synchronize" colcon's configured log level with the other library. This function can be used to determine what level colcon's console logging is set to.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #650 +/- ##
=======================================
Coverage 83.23% 83.24%
=======================================
Files 66 66
Lines 3842 3849 +7
Branches 758 760 +2
=======================================
+ Hits 3198 3204 +6
Misses 556 556
- Partials 88 89 +1 ☔ View full report in Codecov by Sentry. |
This library is directly used by colcon and the debug messages may be useful when debugging colcon itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When colcon routes log messages to log files at a different level from the console, it makes it a little more convoluted to determine what log level is actually set.
When we're utilizing non-colcon libraries that also use python's logging module (e.x. ros_buildfarm, rosdistro, etc), we'll typically want to "synchronize" colcon's configured log level with the other library. This function can be used to determine what level colcon's console logging is set to.