-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] - attempt to use "internal" pattern to fix circular deps #231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Thank you very much for the quick answer and my apologies, I was too overhyped when read your article :D
@colinhacks please let me know your opinion on how should we proceed to fix the original problem (#215) this PR attempts to solve:
Arguments:
I suggest to completely fix circular dependencies by applying strategy described in #227
|
Closing in favor of #226 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to use internal pattern that @colinhacks proposed to use in this comment.
Unfortunately, it doesn't seem to resolve the problem.
Now, the circular dependency appears to be between
internal
<=>module
s (that depend on other modules, thru the use ofinternal
).@mweststrate I apologize for pinging and please feel free to ignore. However, it'd be wonderful to know the view of the author of this pattern. Thank you :)
Result: