Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial prototype fix for issue #2651 #2652

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

ddurschlag
Copy link
Contributor

@ddurschlag ddurschlag commented Aug 14, 2023

Uses a non-arrow function to maintain this.

Closes #2651

@netlify
Copy link

netlify bot commented Aug 14, 2023

Deploy Preview for guileless-rolypoly-866f8a ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit dbf7347
🔍 Latest deploy log https://app.netlify.com/sites/guileless-rolypoly-866f8a/deploys/64dac3f8a5e5a30008403667
😎 Deploy Preview https://deploy-preview-2652--guileless-rolypoly-866f8a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ddurschlag
Copy link
Contributor Author

Known problems:

  1. Only applies to sync functions (easy fix, just haven't done it)
  2. Not clear if there's a performance impact
  3. Not clear if this is better than a proxy-based approach
  4. Involves this-aliasing that eslint does not approve of
  5. Test might be considered anemic? Not sure if I should be adding other tests.

Would love maintainer opinions or code suggestions on any of the above.

@colinhacks colinhacks merged commit 932cc47 into colinhacks:master Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zod.function as property of zod.object loses this
2 participants