-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for base64url
strings
#3712
Add support for base64url
strings
#3712
Conversation
✅ Deploy Preview for guileless-rolypoly-866f8a ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The new method should probably also be added to https://github.com/colinhacks/zod/blob/main/README.md#strings, but I didn’t want to predict the version number under which this feature may be released. |
I like the spirit, but I'm not sure I like the implementation. If the idea is "parse, don't validate", then maybe it would be more on-brand to provide a transform to get at the represented binary data, rather than just validate the string unchanged. (of course the same goes for the existing |
Parsing the encoded data into a buffer would be an interesting opt-in feature given that people are only interested in the binary data. My main use case for |
070c899
to
05c4922
Compare
lgtm! |
Fixes colinhacks#3711 Signed-off-by: Marvin A. Ruder <signed@mruder.dev>
Signed-off-by: Marvin A. Ruder <signed@mruder.dev>
Signed-off-by: Marvin A. Ruder <signed@mruder.dev>
13bc1db
to
8976023
Compare
Fixes #3711