Don't include received value in enum/literal error messages (fixes #461) #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(could be sensitive or unsafe to log)
Also, don't include the received value (could be sensitive or unsafe to log)
scotttrinh
approved these changes
Nov 22, 2021
There was a problem hiding this comment.
I support this stance in general, and this PR in particular looks good to me! I'm not sure what we consider our "compatibility" responsibility with regards to message strings, so I'd love to here from @colinhacks before merging.
|
LGTM - Changes to error language don't merit a major version bump imo so let's merge I'll publish a minor release with this and some other changes this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #461
Also the error produced by
ZodLiteraldid not actually match theZodInvalidTypeIssueinterface orERROR_HANDLING.mddocumentation (expectedandreceivedwere not actuallyZodParsedTypes)