Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRYD-999: Audit Record Sidebar Panel #144

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

mikejritter
Copy link
Contributor

@mikejritter mikejritter commented Mar 30, 2022

Resolves: https://collectionspace.atlassian.net/browse/DRYD-999

  • Create sidebar panel for navigating back to the record for an audit

Notes

  • The header for the related record is not the same as what is in the wireframes. I set narrow as the column set which seems to have made it the same as other search results.
  • I just saw there was a request to add the Open button back in, need to set the SearchPanel to show the search button

@mikejritter mikejritter marked this pull request as ready for review March 31, 2022 18:46
@mikejritter
Copy link
Contributor Author

Just pushed changes for the two issues mentioned in the notes. For the columns, the recordType was not being set correctly as the formatting was off when coming from an audited record.

@mikejritter
Copy link
Contributor Author

I noticed on the v7.1-ucb-contributions branch this is returning multiple items in the sidebar, so I need to look into why this is occurring before this is ready for review.

@mikejritter
Copy link
Contributor Author

Found out the bug I saw was my own fault from the earlier change to the searchDescriptor. I updated this to use an advanced search on the ecm:name field instead for querying a single csid. I also updated the pathToNXQL function to account for the ecm field as it was concatenating with an empty nxqlPath.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant