DRYD-1259: Fix repeated search panel requests when login has expired.

[ray-lee]

What does this do?

This correctly connects the searchError prop of the SearchPanel component to state from the Redux store. Previously, searchError was not being set, even though it was needed for proper functioning of the SearchPanel. It also tweaks the conditions under which SearchPanel executes a new search.

Why are we doing this? (with JIRA link)

This fixes a bug where the SearchPanel would issue a new search whenever a search resulted in an error. When the error was a 401 due to not being logged in, this would cause an endless loop of searches.

JIRA: https://collectionspace.atlassian.net/browse/DRYD-1259

How should this be tested? Do these changes have associated tests?

• Log in using the UI
• Do a keyword search on a record type
• Open the Network panel in the developer tools
• Restart tomcat, so that all active tokens are invalidated
• In the UI, select a different record type in the keyword search box, and click the search button

Expect: A single request is made to populate the Reports sidebar, and another single request is made to populate the Data Updates (batch) sidebar. The requests should return 401 errors. The requests should not be repeated after the 401 errors.

Dependencies for merging? Releasing to production?

None.

Has the application documentation been updated for these changes?

n/a

Did someone actually run this code to verify it works?

@ray-lee ran this locally.

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (5baa689) 96.58% compared to head (0cffa48) 96.58%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #187   +/-   ##
=======================================
  Coverage   96.58%   96.58%           
=======================================
  Files         550      550           
  Lines       10936    10936           
  Branches     1226     1226           
=======================================
  Hits        10563    10563           
  Misses         38       38           
  Partials      335      335           

Files Changed	Coverage Δ
src/components/search/SearchPanel.jsx	93.54% <ø> (ø)
src/containers/search/SearchPanelContainer.js	100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.