Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRYD-1299: Update color to meet expected contrast ratio #198

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

mikejritter
Copy link
Contributor

What does this do?

  • Updates the color of active navlink elements to meet the expected contrast ratio

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1299

This is part of the wcag audit, and is to fix the contrast ratio for active nav link elements.

How should this be tested? Do these changes have associated tests?

  • Run the devserver and navigate using the nav bar
  • Observe that the active element has a contrast ratio of at least 4.5:1

Dependencies for merging? Releasing to production?
None, though I'm wondering if there's a way to check some of the accessibility updates in the test suite. Seems like it would be nice to have, though not strictly necessary.

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter tested locally

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (90c22fe) 95.47% compared to head (fcb5ca9) 95.47%.
Report is 3 commits behind head on master.

❗ Current head fcb5ca9 differs from pull request most recent head cf38d05. Consider uploading reports for the commit cf38d05 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #198   +/-   ##
=======================================
  Coverage   95.47%   95.47%           
=======================================
  Files         555      555           
  Lines       10899    10899           
  Branches     1196     1196           
=======================================
  Hits        10406    10406           
  Misses        147      147           
  Partials      346      346           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ray-lee ray-lee merged commit e57320d into collectionspace:master Feb 2, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants