Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus order updates for record page #210

Merged
merged 6 commits into from
Apr 30, 2024

Conversation

mikejritter
Copy link
Contributor

What does this do?

  • Render the sidebar toggle button as part of the record sidebar
  • Update css to keep sidebar styling consistent with previous behavior

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1309

These are similar changes to those in #209 but for the record page. This makes the tab ordering logically consistent by having the sidebar toggle button be part of the record sidebar.

How should this be tested? Do these changes have associated tests?

  • Run the devserver
  • Create a new record (group is a good choice as it's small)
  • Cycle through the focusable elements using tab
    • The expected order is to go through the record form, then then sidebar toggle, then the sidebar
  • Toggle and untoggle the sidebar and see that the form fills to the width of the page

Dependencies for merging? Releasing to production?
None

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter tested against a local instance

Copy link
Member

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ray-lee ray-lee merged commit 35e953a into collectionspace:master Apr 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants