Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRYD-1495: Relabel culture authorities #235

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

mikejritter
Copy link
Contributor

What does this do?

  • Relabel culture authorities

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1495

This is to update the label of ethculture to cultural group, which makes more sense conceptually with how it works. I also noticed that archculture was labeled differently compared to anthro so I adjusted it to be in line with that.

How should this be tested? Do these changes have associated tests?

  • Run the devserver npm run devserver --back-end=https://core.dev.collectionspace.org
  • Check that ethculture and archculture display their updated labels

Dependencies for merging? Releasing to production?
None

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter tested using core.dev as a backend

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.18%. Comparing base (b1453d4) to head (300e704).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #235   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files         590      590           
  Lines       12682    12682           
  Branches     2593     2607   +14     
=======================================
  Hits        12452    12452           
  Misses        227      227           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikejritter mikejritter changed the title Dryd 1495 DRYD-1495: Relabel culture authorities Sep 4, 2024
Copy link
Member

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ray-lee ray-lee merged commit b147ef7 into collectionspace:master Sep 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants