Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRYD-1517: Chronology Search Sort Order #237

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

mikejritter
Copy link
Contributor

@mikejritter mikejritter commented Sep 10, 2024

What does this do?

  • Fixes typo in field names for chronology search

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1517

This fixes a bug when searching on Chronology authorities. Currently the wrong field is being used, so ERR_API is being returned in the search form (a 400 from the back end). This is being caused by the terms having the wrong name (citationTermGroupList), which does not exist in the chronology schema.

How should this be tested? Do these changes have associated tests?

  • Run the devserver, e.g. npm run devserver --back-end https://core.dev.collectionspace.org
  • Search on Chronology authorities
  • Use the sort functionality to sort by display name and term status

Dependencies for merging? Releasing to production?
None

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter tested locally

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.18%. Comparing base (b147ef7) to head (ea7d61c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #237   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files         590      590           
  Lines       12682    12682           
  Branches     2607     2607           
=======================================
  Hits        12452    12452           
  Misses        227      227           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ray-lee ray-lee merged commit 4a51efa into collectionspace:master Sep 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants