Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRYD-1393: Support Multiple Related Record Sidebars #239

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

mikejritter
Copy link
Contributor

@mikejritter mikejritter commented Sep 20, 2024

What does this do?

  • Allow for multiple related records panels
  • Add serviceTag for querying on sets of records

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1393

This is a WIP atm I'll update later with a full description

How should this be tested? Do these changes have associated tests?

  • Add a sidebar.js (e.g. heldintrust/sidebar.js)
export default {
  relatedRecords: [{
    recordType: 'collectionobject',
  }, {
    recordType: 'procedure',
    serviceTag: '-nagpra',
  }, {
    id: 'nagpra',
    recordType: 'procedure',
    serviceTag: 'nagpra',
  }],
};
  • Update the index.js to include the sidebar
  • Add a message for the new record panel to messages.js
   sidebar: defineMessages({
     nagpra: {
       id: 'panel.heldintrust.nagpra',
       defaultMessage: 'NAGPRA',
     },
   }),

Dependencies for merging? Releasing to production?

Has the application documentation been updated for these changes?

Did someone actually run this code to verify it works?

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.17%. Comparing base (f16c895) to head (48ae276).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #239      +/-   ##
==========================================
- Coverage   98.18%   98.17%   -0.01%     
==========================================
  Files         597      597              
  Lines       12716    12720       +4     
  Branches     2595     2613      +18     
==========================================
+ Hits        12485    12488       +3     
- Misses        228      229       +1     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikejritter mikejritter marked this pull request as ready for review September 27, 2024 16:12
@mikejritter
Copy link
Contributor Author

@ray-lee I forgot to mark this as ready the other day - it's good to be reviewed now as well.

Copy link
Member

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ray-lee ray-lee merged commit 020cb7a into collectionspace:master Sep 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants