Skip to content

Commit

Permalink
Solve_issue_868 (#870)
Browse files Browse the repository at this point in the history
* Issue correction # 868 by using the drop event to select the target row

* Update CHANGES.rst

* Update CHANGES.rst

User in a new line.

* Update layout.js

Fixed indentation using 2 spaces.

* Update CHANGES.rst

Fixed identation
  • Loading branch information
Mubra authored and hvelarde committed Oct 2, 2019
1 parent 8b3c5c8 commit 588edf1
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
6 changes: 5 additions & 1 deletion CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,11 @@ There's a frood who really knows where his towel is.
2.2.1 (unreleased)
^^^^^^^^^^^^^^^^^^

- The 'drop' event and its 'target' method are used to obtain the element (column) and not generate ambiguity (fixes `#861 <https://github.com/collective/collective.cover/issues/861>`_). [Mubra]
- A "row" object is generated and its location in the DOM is added with the even "drop.target" (fixes `#868 <https://github.com/collective/collective.cover/issues/868>`_).
[Mubra]

- The 'drop' event and its 'target' method are used to obtain the element (column) and not generate ambiguity (fixes `#861 <https://github.com/collective/collective.cover/issues/861>`_).
[Mubra]


2.2.0 (2019-02-26)
Expand Down
5 changes: 4 additions & 1 deletion webpack/app/js/layout.js
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,10 @@ export default class LayoutView {

//allow columns droppable
let onDrop = function(e, ui) {
this.row_drop(rows);
//the origin row is taken with the "drop" event
let helprows = this.row_dom.clone();
helprows['0']=e.target;
this.row_drop(helprows);
};
rows.droppable({
activeClass: 'ui-state-default',
Expand Down

0 comments on commit 588edf1

Please sign in to comment.