Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove code from Image and Link tiles #301

Closed
hvelarde opened this issue Oct 1, 2013 · 2 comments · Fixed by #307
Closed

Remove code from Image and Link tiles #301

hvelarde opened this issue Oct 1, 2013 · 2 comments · Fixed by #307
Assignees
@fulv
Labels
bug
Milestone
1.0a6

Comments

@hvelarde
Copy link
Member

hvelarde commented Oct 1, 2013

We forgot to remove this on 1.0a5.

related with #218.
@ghost ghost assigned fulv Oct 8, 2013
fulv added a commit to fulv/collective.cover that referenced this issue Oct 8, 2013
@fulv
Issue collective#301 - Remove code from Image and Link tiles
70dd8a0
@fulv fulv mentioned this issue Oct 8, 2013
Merged
@vangheem
Copy link
Member

This change breaks existing covers that have image and link tiles.

@hvelarde
Copy link
Member Author

yes, and this was expected since release 1.0a4: https://github.com/collective/collective.cover/blob/master/CHANGES.rst#10a4-2013-07-27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fulv fulv

Labels
bug
Projects
None yet
Milestone
1.0a6
Development

Successfully merging a pull request may close this issue.

Issue 301 "Remove code from Image and Link tiles" fulv/collective.cover
3 participants
@hvelarde @fulv @vangheem