Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 543 - Add plone.app.widgets support for tile rich text #575

Merged
merged 1 commit into from
Jan 20, 2016

Conversation

rodfersou
Copy link
Member

fixes #543

@hvelarde
Copy link
Member

@rodfersou we have a bunch of broken tests

@@ -24,7 +24,7 @@ ${search_results_number_selector} xpath=//strong[@id='search-results-number']

*** Test cases ***

Test RichText Tile is Searchable
Test RichTextTile is Searchable
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was running two tests instead of one when I use the command

$ ./bin/test --layer Robot -t "Test RichText Tile"

@rodfersou rodfersou force-pushed the issue_543 branch 3 times, most recently from c371cd2 to 776106a Compare January 18, 2016 14:33
Click Link css=${edit_link_selector}
Wait For Condition return typeof tinyMCE !== "undefined" && tinyMCE.activeEditor !== null && document.getElementById(tinyMCE.activeEditor.id) !== null

Sleep 1s Wait for tinymce to load
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you take out this line it will break for plone 4.2
https://en.wikipedia.org/wiki/Heisenbug

hvelarde added a commit that referenced this pull request Jan 20, 2016
Issue 543 - Add plone.app.widgets support for tile rich text
@hvelarde hvelarde merged commit 5540c70 into master Jan 20, 2016
@hvelarde hvelarde deleted the issue_543 branch January 20, 2016 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RichText Edit broken when plone.app.widgets is installed
2 participants