Avoid KeyError when tile schema has changed #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodfersou
reviewed
Sep 11, 2018
| if field_name not in fields: | ||
| continue # tile schema has changed | ||
|
|
||
| if not isinstance(field_conf, dict): |
There was a problem hiding this comment.
in what case this is not a dict?
There was a problem hiding this comment.
(Pdb) pp conf.items()
[('css_class', ''),
('link_url', {'htmltag': u'h2', 'order': u'2', 'visibility': u'on'}),
('link_text', {'htmltag': u'h2', 'order': u'1', 'visibility': u'on'}),
('title', {'htmltag': u'h2', 'order': u'0', 'visibility': u'on'})]
|
I'm going to do it later: this is an issue on brasil.gov.tiles for IDG 1.2 and we're not responsible for that. I'm still not pretty sure on how to fix it; we will probably need a monkey patch. |
|
@hvelarde after run the upgrade, tell us if this did not cause inconsistencies. |
|
I already did it and I saw no issues: it just skips any field no longer present in the tile schema. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs. plonegovbr/brasil.gov.portal#524