New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix callbacks not being created when updating audit options #751

Open

chaadow wants to merge 1 commit into collectiveidea:main from chaadow:fix_callbacks_on_audited_update

chaadow commented Dec 24, 2024 •

edited

Loading

The main use case is that audited allows users to update the audited options by calling audited multiple times.

# This create two callbacks `after_update` and `after_destroy`
audited on: [:update, :destroy]

# Now if we call audited a second time
# this unfortunately won't create the `after_create` callback when updating the configuration
audited on: [:update, :destroy, :create]

This pull requests fixes the issue so that it creates callbacks only for added configuration, in the example above it's the create one.


          Fix callbacks not being created when updating audit options

4c80fbe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet