Feature/continuous logging #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replacing connectionwindow.ui with own version
uncommenting function declaration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Collin,
Great work with SavvyCAN!
I played a bit with it last year and added some features.
I tried to sort each feature in a branch so you can find your way through it.
It seems to me that continuous logging doesn't work well when in overwrite mode (messages that are not overwritten/re-received are written again to the log file). I changed the implementation of continuous logging so that it saves all received messages.
It means that filters are ignored when logging through continuous logging (that way you can observe specific messages while recording all traffic)
Please forgive any style mistakes: I haven't much experience with C++ but the code should work!
If you have any questions do not hesitate
Cheers