Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Migrate Bot test #2382

Closed
collinbarrett opened this issue May 10, 2021 · 4 comments
Closed

fix Migrate Bot test #2382

collinbarrett opened this issue May 10, 2021 · 4 comments
Assignees
@collinbarrett
Labels
bug something isn't working directory-migrations automatic FilterLists data migration on PRs

Comments

@collinbarrett
Copy link
Owner

collinbarrett commented May 10, 2021 •
edited
Loading

This step should've failed due to FK failure in #2381 .

Maybe running test async causes pipeline not to wait?
@collinbarrett collinbarrett added bug something isn't working directory-migrations automatic FilterLists data migration on PRs high priority must fix ASAP labels May 10, 2021
@collinbarrett collinbarrett self-assigned this May 10, 2021
@collinbarrett collinbarrett mentioned this issue May 24, 2021
Merged
@collinbarrett
Copy link
Owner Author

This needs to get fixed before more data changes can be safely made. Not sure what's going on...

This was linked to pull requests Jul 20, 2021
temp(directory-data): 📄🚧 test migration pipeline (should fail due to FK) #2470
Closed
temp(directory): 🚧 break data to trigger migrations test failure #2471
Closed
This was referenced Jul 20, 2021
Merged
Merged
Merged
Merged
Merged
@collinbarrett
Copy link
Owner Author

collinbarrett commented Oct 29, 2021 •
edited
Loading

hmm. might be related to size of Migrations dir.

ref #2618 & https://dev.azure.com/collinbarrett/FilterLists/_build/results?buildId=6688&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=ebf69b98-7e9b-5a4b-1523-fc9437d68b9b

@collinbarrett
Copy link
Owner Author

yeah, maybe resetting migrations on every data PR will be a good temp fix.

@collinbarrett collinbarrett removed the high priority must fix ASAP label Nov 2, 2021
@collinbarrett
Copy link
Owner Author

closing for now. not worth fixing as efforts are focused on #372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@collinbarrett collinbarrett

Labels
bug something isn't working directory-migrations automatic FilterLists data migration on PRs
Projects
None yet
Milestone
No milestone
1 participant
@collinbarrett