Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hopefully this should add our filter list to the site #2465

Merged
merged 8 commits into from
Oct 21, 2021

Conversation

Arctic-Circle-System
Copy link
Contributor

We didn't do it before because the data model thing and the process in general is intimidating. Hopefully this works and this list is useful to people. We're still working on it and are still confused as to how we update our list once it's on the site (do we just edit our list like we normally do and it should work fine? or do we have to edit a json file when we do?). ~Red

@Arctic-Circle-System
Copy link
Contributor Author

can someone please help us with this? I don't think it's working ~Red

@collinbarrett
Copy link
Owner

I recently got back from a long vacation and am still catching up on things. I'll review and assist where I can soon. Thanks!

@collinbarrett collinbarrett added the directory-data changes to basic FilterLists data label Jul 20, 2021
@collinbarrett collinbarrett self-assigned this Jul 20, 2021
@collinbarrett
Copy link
Owner

blocked by #2382

services/Directory/data/FilterList.json Outdated Show resolved Hide resolved
services/Directory/data/FilterList.json Outdated Show resolved Hide resolved
services/Directory/data/FilterList.json Outdated Show resolved Hide resolved
services/Directory/data/FilterList.json Outdated Show resolved Hide resolved
services/Directory/data/FilterList.json Outdated Show resolved Hide resolved
services/Directory/data/FilterList.json Show resolved Hide resolved
@Arctic-Circle-System
Copy link
Contributor Author

Wait I don't think I did this right, I thought it was pushing to our fork. ~Charlie

collinbarrett added a commit to Arctic-Circle-System/FilterLists that referenced this pull request Jul 22, 2021
collinbarrett added a commit to Arctic-Circle-System/FilterLists that referenced this pull request Jul 22, 2021
@collinbarrett
Copy link
Owner

I think your change is all fixed up and good to go now. I'm going to keep this open for a tad longer to try to fix #2382 which is blocking a few other PRs as well. Nothing else you need to do at the moment but give me a bit of patience.

Thanks!

@Arctic-Circle-System
Copy link
Contributor Author

Thank you. So to update the filter list do we have to mess with anything in the FilterLists repo or do we just update it in our own repo? ~Red

@collinbarrett
Copy link
Owner

You did the right thing here. Fork the FilterLists repository. Make changes to the .json files. Submit a Pull Request back into this FilterLists repo. 👍

@Arctic-Circle-System
Copy link
Contributor Author

Fork it for every update, got it. Which JSON files would we have to modify to update our list? Still confused on that 😅 ~Charlie

@collinbarrett
Copy link
Owner

Hmm, I'm not totally sure I understand your question.

So, FilterLists is just a directory of "meta"-information about lists. So, yes, if you have a change to your list such as maybe your contact email address changes, you can certainly submit a PR to the FilterLists repo changing any data in here.

A few other links that could be useful:

^this process is certainly difficult and painful. eventually, we hope to make it easier using something like #372

@Arctic-Circle-System
Copy link
Contributor Author

Like if I add new URLs would we have to do that? ~Charlie

@collinbarrett
Copy link
Owner

No, you don't need to update anything in the FilterLists repo every time rules are added to your list.

@collinbarrett
Copy link
Owner

Mmm, sorry, we got some merge conflicts now due to multiple PRs happening at once. I can try to help fix when I have time.

@Arctic-Circle-System
Copy link
Contributor Author

Alright, we'll wait ~Red

@Arctic-Circle-System
Copy link
Contributor Author

Hey uh... Is our list going to be added soon? There doesn't seem to have been an update on this in months. ~Red

@collinbarrett collinbarrett removed their assignment Oct 8, 2021
@collinbarrett
Copy link
Owner

I haven't had a chance. Sorry. It'll be at least another week before I have time, but feel free to look into it if you have time. we just gotta resolve the merge conflict.

Co-authored-by: Collin M. Barrett <collinbarrett@users.noreply.github.com>
Co-authored-by: Collin M. Barrett <collinbarrett@users.noreply.github.com>
Co-authored-by: Collin M. Barrett <collinbarrett@users.noreply.github.com>
Co-authored-by: Collin M. Barrett <collinbarrett@users.noreply.github.com>
@collinbarrett collinbarrett merged commit 96457cf into collinbarrett:master Oct 21, 2021
collinbarrett added a commit that referenced this pull request Oct 21, 2021
collinbarrett added a commit that referenced this pull request Oct 21, 2021
collinbarrett added a commit that referenced this pull request Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
directory-data changes to basic FilterLists data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants